Skip to content

feat: add tpcds cmd#303

Merged
fengluodb merged 1 commit intomainfrom
feature/add-tpcds-cmd
Apr 8, 2024
Merged

feat: add tpcds cmd#303
fengluodb merged 1 commit intomainfrom
feature/add-tpcds-cmd

Conversation

@fengluodb
Copy link
Copy Markdown
Contributor

@fengluodb fengluodb commented Apr 7, 2024

No description provided.

@github-actions github-actions Bot added the size/L Denotes a PR that changes 100-499 lines. label Apr 7, 2024
@fengluodb fengluodb linked an issue Apr 7, 2024 that may be closed by this pull request
[Features] Bench support tpcds benchmark #304
Closed
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 13.57143% with 121 lines in your changes are missing coverage. Please review.

Project coverage is 43.16%. Comparing base (5e7e10e) to head (20da28f).

Files Patch % Lines
pkg/cmd/bench/tpcds.go 12.40% 119 Missing and 1 partial ⚠️
pkg/cmd/bench/tpch.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   43.29%   43.16%   -0.14%     
==========================================
  Files         217      218       +1     
  Lines       29147    29287     +140     
==========================================
+ Hits        12620    12642      +22     
- Misses      14976    15094     +118     
  Partials     1551     1551
Flag Coverage Δ
unittests 43.16% <13.57%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ldming
ldming approved these changes Apr 8, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ldming ldming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengluodb fengluodb merged commit 8cd5bbd into main Apr 8, 2024
@fengluodb fengluodb deleted the feature/add-tpcds-cmd branch April 8, 2024 01:15
@github-actions github-actions Bot added this to the Release 0.9.0 milestone Apr 8, 2024
@ahjing99
Copy link
Copy Markdown
Collaborator

ahjing99 commented Apr 8, 2024

/cherry-pick release-0.9

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 8, 2024

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/8595205388

github-actions Bot pushed a commit that referenced this pull request Apr 8, 2024
@fengluodb @ahjing99
feat: add tpcds cmd (#303)
2433d31 
(cherry picked from commit 8cd5bbd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldming ldming ldming approved these changes

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@wangyelei wangyelei Awaiting requested review from wangyelei wangyelei is a code owner

@leon-inf leon-inf Awaiting requested review from leon-inf

@1aal 1aal Awaiting requested review from 1aal 1aal is a code owner

Assignees

No one assigned

Labels

size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Milestone

Release 0.9.0

Development

Successfully merging this pull request may close these issues.

[Features] Bench support tpcds benchmark

4 participants

@fengluodb @codecov-commenter @ahjing99 @ldming